Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show TextureProgressBar radial center cross only when editing the scene #99685

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Show TextureProgressBar radial center cross only when editing the scene #99685

merged 1 commit into from
Nov 29, 2024

Conversation

arkology
Copy link
Contributor

@arkology arkology commented Nov 25, 2024 •
edited by KoBeWi
Loading

Closes #46266 Closes #96859 for real. Nothing more.
Special thanks to @Mickeon
godot windows editor dev x86_64_frtvhxH0pr

@arkology arkology requested a review from a team as a code owner November 25, 2024 18:02
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 25, 2024
@AThousandShips AThousandShips added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 25, 2024
AThousandShips
AThousandShips approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

akien-mga
akien-mga approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akien-mga akien-mga merged commit dbb9c99 into godotengine:master Nov 29, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@arkology arkology deleted the texture-progress-cross-plugin-friendly branch November 30, 2024 06:50
@arkology arkology mentioned this pull request Nov 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:editor topic:gui
Projects
None yet
Milestone
4.4
3 participants
@arkology @akien-mga @AThousandShips